netdev - Re: [PATCH net-next v2 0/6] Add comphy support for Armada 38x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <295924f0-1007-4b39-189b-1b21e4bf1b86@ti.com>
Date:   Fri, 8 Feb 2019 14:52:26 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        David Miller <davem@...emloft.net>
CC:     <linux@...linux.org.uk>, <andrew@...n.ch>,
        <gregory.clement@...tlin.com>, <jason@...edaemon.net>,
        <sebastian.hesselbarth@...il.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <mark.rutland@....com>,
        <netdev@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH net-next v2 0/6] Add comphy support for Armada 38x

Hi,

On 08/02/19 1:28 PM, Thomas Petazzoni wrote:
> Hello David,
> 
> On Thu, 07 Feb 2019 18:10:49 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Russell King - ARM Linux admin <linux@...linux.org.uk>
>> Date: Thu, 7 Feb 2019 16:18:25 +0000
>>
>>> This series adds support for the comphy for Armada 38x, which allows
>>> these SoCs to use 2500BASE-X mode with appropriate SFP modules.
>>>
>>> Tested on SolidRun Clearfog after updating for the 5.0 merge window
>>> changes.  
>>
>> Series applied, thanks Russell.
> 
> This series contained:
> 
>  - Device Tree bindings that had not been ACKed by the DT bindings
>    maintainers, one of which should have been merged through the
>    drivers/phy maintainer tree.
> 
>  - A brand new drivers/phy driver that had not been ACKed by the
>    drivers/phy maintainer.

The PHY driver looks good to me. But I think it might still be better to take
it via PHY tree since there are other Marvell drivers that are getting merged
and will result in conflicts in Kconfig and Makefile.

Thanks
Kishon