netdev - RE: [PATCH bpf-next] tools/bpf: add missing strings.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a2d49f7e04f4ec880ce48cbc2a53235@AcuMS.aculab.com>
Date:   Fri, 8 Feb 2019 10:23:19 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Andrii Nakryiko' <andriin@...com>, "yhs@...com" <yhs@...com>,
        "songliubraving@...com" <songliubraving@...com>,
        "ast@...com" <ast@...com>, "kafai@...com" <kafai@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-team@...com" <kernel-team@...com>
Subject: RE: [PATCH bpf-next] tools/bpf: add missing strings.h include

From: Andrii Nakryiko
> Sent: 07 February 2019 17:50
> 
> Few files in libbpf are using bzero() function (defined in strings.h header), but
> don't include corresponding header. When libbpf is added as a dependency to pahole,
> this undeterministically causes warnings on some machines:
> 
> bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimplicit-function-declaration]
>   bzero(&attr, sizeof(attr));
>     ^~~~~

Wouldn't it be better to change these to the more portable memset()?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)