netdev - Re: [PATCH] net: hso: do not unregister if not registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190209.093551.1941095439637753471.davem@davemloft.net>
Date:   Sat, 09 Feb 2019 09:35:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tuba@....ufl.edu
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: hso: do not unregister if not registered

From: "Yavuz, Tuba" <tuba@....ufl.edu>
Date: Sat, 9 Feb 2019 16:24:20 +0000

> 
> 
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
> 
> Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>

Your patch is still corrupted.

Email this patch to yourself and try to apply it to a source tree.
You will see that it won't work.

Please do not post this patch again until you have fixed this problem
and have also successfully applied a patch you have test emailed to
yourself.

Thanks.