netdev - Re: [PATCH] net: hso: do not unregister if not registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1549670577031.62975@ece.ufl.edu>
Date:   Sat, 9 Feb 2019 00:02:56 +0000
From:   "Yavuz, Tuba" <tuba@....ufl.edu>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: hso: do not unregister if not registered

I just resubmitted the patch and made sure to send it in plaintext. Hopefully, it will work this time.

Best,

Tuba 
________________________________________
From: David Miller <davem@...emloft.net>
Sent: Friday, February 8, 2019 6:08 PM
To: Yavuz, Tuba
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] net: hso: do not unregister if not registered

From: "Yavuz, Tuba" <tuba@....ufl.edu>
Date: Wed, 6 Feb 2019 00:40:31 +0000

>
> On an error path inside the hso_create_net_device function of the hso
> driver, hso_free_net_device gets called. This causes potentially a
> negative reference count in the net device if register_netdev has not
> been called yet as hso_free_net_device calls unregister_netdev
> regardless. I think the driver should distinguish these cases and call
> unregister_netdev only if register_netdev has been called.
>
> Signed-off-by: Tuba Yavuz <tuba@....ufl.edu>

This patch is corrupted by your email client.