[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190208.225802.704784915757139721.davem@davemloft.net>
Date: Fri, 08 Feb 2019 22:58:02 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: gustavo@...eddedor.com
Cc: andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: use struct_size() in devm_kzalloc()
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Thu, 7 Feb 2019 19:16:03 -0600
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> struct boo entry[];
> };
>
> size = sizeof(struct foo) + count * sizeof(struct boo);
> instance = alloc(size, GFP_KERNEL)
>
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
>
> instance = alloc(struct_size(instance, entry, count), GFP_KERNEL)
>
> Notice that, in this case, variable size is not necessary, hence it is
> removed.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Applied.
Powered by blists - more mailing lists