netdev - Re: [PATCH v2 net-next] net: phy: disregard "Clause 22 registers present" bit in get_phy_c45_devs_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190208.231100.2168035998559471182.davem@davemloft.net>
Date:   Fri, 08 Feb 2019 23:11:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: phy: disregard "Clause 22 registers
 present" bit in get_phy_c45_devs_in_pkg

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Fri, 8 Feb 2019 19:25:22 +0100

> Bit 0 in register 1.5 doesn't represent a device but is a flag that
> Clause 22 registers are present. Therefore disregard this bit when
> populating the device list. If code needs this information it
> should read register 1.5 directly instead of accessing the device
> list.
> Because this bit doesn't represent a device don't define a
> MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for
> the flag in the device list bitmap.
> 
> v2:
> - make masking of bit 0 more explicit
> - improve commit message
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks Heiner.