lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190209170120.GE30856@lunn.ch> Date: Sat, 9 Feb 2019 18:01:20 +0100 From: Andrew Lunn <andrew@...n.ch> To: Tristram.Ha@...rochip.com Cc: Sergio Paracuellos <sergio.paracuellos@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Pavel Machek <pavel@....cz>, UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org Subject: Re: [PATCH v1 net-next 3/4] net: dsa: microchip: use readx_poll_time for polling On Thu, Feb 07, 2019 at 08:07:08PM -0800, Tristram.Ha@...rochip.com wrote: > From: Tristram Ha <Tristram.Ha@...rochip.com> > > Replace register polling functions using timeout with readx_poll_time call. > > Signed-off-by: Tristram Ha <Tristram.Ha@...rochip.com> > --- > drivers/net/dsa/microchip/ksz9477.c | 91 +++++++++++-------------------------- > 1 file changed, 27 insertions(+), 64 deletions(-) > > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > index 4502e13..8391b9e 100644 > --- a/drivers/net/dsa/microchip/ksz9477.c > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -114,28 +114,11 @@ static void ksz9477_port_cfg32(struct ksz_device *dev, int port, int offset, > data; \ > }) > > -static int ksz9477_wait_vlan_ctrl_ready(struct ksz_device *dev, u32 waiton, > - int timeout) > -{ > - u8 data; > - > - do { > - ksz_read8(dev, REG_SW_VLAN_CTRL, &data); > - if (!(data & waiton)) > - break; > - usleep_range(1, 10); > - } while (timeout-- > 0); > - > - if (timeout <= 0) > - return -ETIMEDOUT; > - > - return 0; Hi Tristram I think it would be better to keep ksz9477_wait_vlan_ctrl_ready(), ksz9477_wait_alu_ready() etc, and change there implementation to use readx_poll_timeout(). The function names act as better documentation for what we are waiting for than the parameters being passed to readx_poll_timeout(). Andrew
Powered by blists - more mailing lists