netdev - Re: [PATCH] net/packet: fix 4gb buffer limit due to overflow check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190209.190114.542890373094719579.davem@davemloft.net>
Date:   Sat, 09 Feb 2019 19:01:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kal.conley@...tris.com
Cc:     willemb@...gle.com, edumazet@...gle.com,
        gregkh@...uxfoundation.org, jeffrey.t.kirsher@...el.com,
        alexander.h.duyck@...el.com, ktkhai@...tuozzo.com,
        vincent.whitchurch@...s.com, lirongqing@...du.com,
        magnus.karlsson@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/packet: fix 4gb buffer limit due to overflow check

From: Kal Conley <kal.conley@...tris.com>
Date: Sat,  9 Feb 2019 21:37:00 +0100

> When calculating rb->frames_per_block * req->tp_block_nr the result
> can overflow. Check it for overflow without limiting the total buffer
> size to UINT_MAX.
> 
> This change fixes support for packet ring buffers >= UINT_MAX.

Please resubmit with a proper signoff and also an appropriate Fixes:
tag.