netdev - Re: [PATCH for-next 2/4] devlink: fix print of uint64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190210123401.66920387@hermes.lan>
Date:   Sun, 10 Feb 2019 12:34:01 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Aya Levin <ayal@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Tal Alon <talal@...lanox.com>,
        Ariel Almog <ariela@...lanox.com>
Subject: Re: [PATCH for-next 2/4]  devlink: fix print of uint64_t

On Sun, 10 Feb 2019 20:28:47 +0200
Aya Levin <ayal@...lanox.com> wrote:

>  This patch prints uint64_t with its corresponding format and avoid implicit
>  cast to uint32_t.
> 
> Signed-off-by: Aya Levin <ayal@...lanox.com>
> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>
> Reported-by: Maria Pasechnik <mariap@...lanox.com>
> ---
>  devlink/devlink.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index a05755385a49..46e2e41c5dfd 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -1628,7 +1628,14 @@ static void pr_out_u64(struct dl *dl, const char *name, uint64_t val)
>  	if (val == (uint64_t) -1)
>  		return pr_out_str(dl, name, "unlimited");
>  
> -	return pr_out_uint(dl, name, val);
> +	if (dl->json_output) {
> +		jsonw_u64_field(dl->jw, name, val);
> +	} else {
> +		if (g_indent_newline)
> +			pr_out("%s %lu", name, val);
> +		else
> +			pr_out(" %s %lu", name, val);
> +	}
>  }
>  
>  static void pr_out_region_chunk_start(struct dl *dl, uint64_t addr)

More conditional code adds bloat and is a nuisance.
Why not use print_u64 that already exists.

I wish devlink used json_print in a more standard manner.