lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190210124222.59c5d0aa@hermes.lan> Date: Sun, 10 Feb 2019 12:42:22 -0800 From: Stephen Hemminger <stephen@...workplumber.org> To: Aya Levin <ayal@...lanox.com> Cc: David Ahern <dsahern@...il.com>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jiri Pirko <jiri@...lanox.com>, Moshe Shemesh <moshe@...lanox.com>, Eran Ben Elisha <eranbe@...lanox.com>, Tal Alon <talal@...lanox.com>, Ariel Almog <ariela@...lanox.com> Subject: Re: [PATCH for-next 4/4] devlink: add health command support On Sun, 10 Feb 2019 20:28:49 +0200 Aya Levin <ayal@...lanox.com> wrote: > + > +static void cmd_health_help(void) > +{ > + pr_err("Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n"); > + pr_err("Usage: devlink health recover DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health diagnose DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health dump show DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health dump clear DEV reporter REPORTER_NAME\n"); > + pr_err("Usage: devlink health set DEV reporter REPORTER_NAME NAME VALUE\n"); > +} > + Minor nit: I prefer that all code and outputs in iproute2 look the same for ease of maintenance and constituency of user experience. Why does devlink not use: static void cmd_health_help(void) { fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n"); fprintf(stderr, " devlink health recover DEV reporter REPORTER_NAME\n"); fprintf(stderr, " devlink health diagnose DEV reporter REPORTER_NAME\n"); ... Or fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n" " devlink health recover DEV reporter REPORTER_NAME\n" " devlink health diagnose DEV reporter REPORTER_NAME\n");
Powered by blists - more mailing lists