lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 12 Feb 2019 00:45:20 +0100
From:   Pablo Neira Ayuso <>
To:     "Gustavo A. R. Silva" <>
Cc:     Jozsef Kadlecsik <>,
        Florian Westphal <>,
        "David S. Miller" <>,,,,
Subject: Re: [PATCH net-next] netfilter: xt_recent: Use struct_size() in

On Thu, Feb 07, 2019 at 06:56:08PM -0600, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> struct foo {
>     int stuff;
>     void *entry[];
> };
> size = sizeof(struct foo) + count * sizeof(void *);
> instance = alloc(size, GFP_KERNEL)
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
> size = struct_size(instance, entry, count);
> instance = alloc(size, GFP_KERNEL)
> Notice that, in this case, variable sz is not necessary, hence it is
> removed.
> This code was detected with the help of Coccinelle.

Applied, thanks.

Powered by blists - more mailing lists