netdev - Re: [PATCH] net: fix IPv6 prefix route residue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Feb 2019 10:36:06 +0800
From:   Zhiqiang Liu <liuzhiqiang26@...wei.com>
To:     David Ahern <dsahern@...il.com>, David Miller <davem@...hat.com>
CC:     <thaller@...hat.com>, <yoshfuji@...ux-ipv6.org>,
        <0xeffeff@...il.com>, <edumazet@...gle.com>,
        <netdev@...r.kernel.org>, <mingfangsen@...wei.com>,
        <zhangwenhao8@...wei.com>, <wangxiaogang3@...wei.com>,
        <zhoukang7@...wei.com>, <kuznet@....inr.ac.ru>
Subject: Re: [PATCH] net: fix IPv6 prefix route residue

> On 2/3/19 9:04 AM, David Miller wrote:
>> From: Zhiqiang Liu <liuzhiqiang26@...wei.com>
>> Date: Sun, 3 Feb 2019 14:10:31 +0800
>>
>>> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t {
>>>  	list_for_each_entry(ifa, &idev->addr_list, if_list) {
>>>  		if (ifa == ifp)
>>>  			continue;
>>> -		if (!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>>> +		if (ifa->prefix_len != ifp->prefix_len ||
>>> +			!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>>>  				       ifp->prefix_len))
>>
>> Please fix the indentation of this conditional, it should be:
>>
>> 		if (ifa->prefix_len != ifp->prefix_len ||
>> 		    !ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>> 				       ifp->prefix_len))
>>
>> Thank you.
Thank you for your suggestion. I have fixed the indentation of the
conditional. In addition, I have used the checkpatch.pl script to check the
patch.
>>
> 
> Needs a Fixes tag too.
> 
> Fixes: 5b84efecb7d9 ("ipv6 addrconf: don't cleanup prefix route for
> IFA_F_NOPREFIXROUTE")
> 
> and cc to that author Thomas Haller <thaller@...hat.com>
> 
> .
> 
Thank you. The Fixes tag is added in the v2 patch.