netdev - RE: [PATCH net-next 2/2] devlink: Fix list access without lock while reading region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB2271CD784C39884B637DEFDCD1650@VI1PR0501MB2271.eurprd05.prod.outlook.com>
Date:   Tue, 12 Feb 2019 16:04:49 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 2/2] devlink: Fix list access without lock while
 reading region



> -----Original Message-----
> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Sent: Tuesday, February 12, 2019 3:01 AM
> To: Parav Pandit <parav@...lanox.com>; Jiri Pirko <jiri@...lanox.com>;
> davem@...emloft.net; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next 2/2] devlink: Fix list access without lock while
> reading region
> 
> Hello!
> 
> On 12.02.2019 10:09, Parav Pandit wrote:
> 
> > While finding the devlink device during region reading, devlink device
> > list is accessed and devlink device is returned without holding a
> > lock. This could lead to user-after-free
> 
>     Use-after-free, perhaps?
> 
Yep. Sending v1 to fix typo.

> > accesses.
> >
> > While at it, add lockdep assert to ensure that all future callers hold
> > the lock when calling devlink_get_from_attrs().
> >
> > Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read
> > command")
> > Signed-off-by: Parav Pandit <parav@...lanox.com>
> > Acked-by: Jiri Pirko <jiri@...lanox.com>
> [...]
> 
> MBR, Sergei