netdev - RE: [PATCH net-next 1/2] devlink: Return right error code in case of errors for region read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB22716467A3B9BE83972C075DD1650@VI1PR0501MB2271.eurprd05.prod.outlook.com>
Date:   Tue, 12 Feb 2019 20:22:36 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     Jiri Pirko <jiri@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 1/2] devlink: Return right error code in case of
 errors for region read



> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Tuesday, February 12, 2019 1:25 PM
> To: Parav Pandit <parav@...lanox.com>
> Cc: Jiri Pirko <jiri@...lanox.com>; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next 1/2] devlink: Return right error code in case of
> errors for region read
> 
> From: Parav Pandit <parav@...lanox.com>
> Date: Tue, 12 Feb 2019 01:09:19 -0600
> 
> > devlink_nl_cmd_region_read_dumpit() misses to return right error code
> > on most error conditions.
> > Return the right error code on such errors.
> >
> > Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read
> > command")
> > Signed-off-by: Parav Pandit <parav@...lanox.com>
> > Acked-by: Jiri Pirko <jiri@...lanox.com>
> 
> This has conflicts with the locking changes I applied earlier today.
> 
> Please respin, thanks.
Ok. sending rebased v2.