lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 12 Feb 2019 09:45:06 +0100
From:   Paul Bolle <>
To:     "Gustavo A. R. Silva" <>
Cc:,,, Kees Cook <>,
        Karsten Keil <>
Subject: Re: [PATCH] ser_gigaset: mark expected switch fall-through

Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> This patch fixes the following warning:
> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:
> drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    switch (arg) {
>    ^~~~~~
> drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here
>   default:
>   ^~~~~~~
> Warning level 3 was used: -Wimplicit-fallthrough=3
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> Signed-off-by: Gustavo A. R. Silva <>

Acked-by: Paul Bolle <>


Paul Bolle

Powered by blists - more mailing lists