netdev - Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190213131647.GD2186@nanopsycho>
Date:   Wed, 13 Feb 2019 14:16:47 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3 net-next] test_objagg: Uninitialized variable in
 error handling

Wed, Feb 13, 2019 at 09:59:31AM CET, dan.carpenter@...cle.com wrote:
>We need to set the error message on this path otherwise some of the
>callers, such as test_hints_case(), print from an uninitialized pointer.
>
>We had a similar bug earlier and set "errmsg" to NULL in the caller,
>test_delta_action_item().  That code is no longer required so I have
>removed it.
>
>Fixes: 9069a3817d82 ("lib: objagg: implement optimization hints assembly and use hints for object creation")
>Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>