netdev - Re: [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec6a8ee-5e6c-8b48-8af5-4a0d316d8f49@microchip.com>
Date:   Wed, 13 Feb 2019 16:55:21 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <albin_yang@....com>, <netdev@...r.kernel.org>
CC:     <Nicolas.Ferre@...rochip.com>, <davem@...emloft.net>,
        <yang.wei9@....com.cn>
Subject: Re: [PATCH net] net: macb: replace dev_kfree_skb_irq by
 dev_consume_skb_irq for drop profiles



On 12.02.2019 18:00, Yang Wei wrote:
> From: Yang Wei <yang.wei9@....com.cn>
> 
> dev_consume_skb_irq() should be called in at91ether_interrupt() when
> skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@....com.cn>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

> ---
>  drivers/net/ethernet/cadence/macb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 2b28826..835cc58 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3763,7 +3763,7 @@ static irqreturn_t at91ether_interrupt(int irq, void *dev_id)
>  			dev->stats.tx_errors++;
>  
>  		if (lp->skb) {
> -			dev_kfree_skb_irq(lp->skb);
> +			dev_consume_skb_irq(lp->skb);
>  			lp->skb = NULL;
>  			dma_unmap_single(NULL, lp->skb_physaddr,
>  					 lp->skb_length, DMA_TO_DEVICE);
>