lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 13 Feb 2019 11:17:34 -0700
From:   shuah <shuah@...nel.org>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     willemb@...gle.com, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH net] selftests: fix timestamping Makefile

On 2/13/19 10:09 AM, Deepa Dinamani wrote:
> The clean target in the makefile conflicts with the generic
> kselftests lib.mk, and fails to properly remove the compiled
> test programs.
> 
> Remove the redundant rule, the TEST_GEN_FILES will be already
> removed by the CLEAN macro in lib.mk.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> ---
> 
> * Changes since v1: as per review comments
> 
>   tools/testing/selftests/networking/timestamping/Makefile | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
>   top_srcdir = ../../../../..
>   KSFT_KHDR_INSTALL := 1
>   include ../../lib.mk
> -
> -clean:
> -	rm -fr $(TEST_GEN_FILES)
> 

Thanks for the patch.

Acked-by: Shuah Khan <shuah@...nel.org>

thanks,
-- Shuah

Powered by blists - more mailing lists