lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f0f1b6ea-9568-c3e9-a92e-43fc87d253c4@solarflare.com> Date: Thu, 14 Feb 2019 09:34:21 +0000 From: Bert Kenward <bkenward@...arflare.com> To: Huang Zijiang <huang.zijiang@....com.cn>, <linux-net-drivers@...arflare.com> CC: <ecree@...arflare.com>, <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <wang.yi59@....com.cn> Subject: Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any On 14/02/2019 06:42, Huang Zijiang wrote: > The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback() > when skb is still used. The skb is be replaced by segments, so the > original skb should be consumed(not drop). > > Signed-off-by: Huang Zijiang <huang.zijiang@....com.cn> Sergei's commit message fixups look good, but apart from that: Acked-by: Bert Kenward <bkenward@...arflare.com> > --- > drivers/net/ethernet/sfc/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c > index c3ad564..ed551f0 100644 > --- a/drivers/net/ethernet/sfc/tx.c > +++ b/drivers/net/ethernet/sfc/tx.c > @@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue, > if (IS_ERR(segments)) > return PTR_ERR(segments); > > - dev_kfree_skb_any(skb); > + dev_consume_skb_any(skb); > skb = segments; > > while (skb) { >
Powered by blists - more mailing lists