netdev - Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <11497659.iQavgr9jVl@bentobox>
Date:   Thu, 14 Feb 2019 15:04:54 +0100
From:   Sven Eckelmann <sven@...fation.org>
To:     Linus Lüssing <linus.luessing@...3.blue>
Cc:     b.a.t.m.a.n@...ts.open-mesh.org,
        David Bauer <mail@...id-bauer.net>,
        Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add multicast-to-unicast support for multiple targets

On Thursday, 14 February 2019 14:44:52 CET Linus Lüssing wrote:
[...]
> > No new sysfs config files.
> 
> Why? The bridge for instance does the same.

https://patchwork.open-mesh.org/patch/16763/ - here the quote

On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote:
> I strongly believe it is a huge mistake to use sysfs for things like
> this. This should be done via generic netlink api.

We don't need to configuration interfaces - we only need the preferred one. If 
this is sysfs for you guys then we should not have started with generic 
netlink at all. And why wasn't this brought up now *after* the stuff was 
merged by David. It isn't the first time that I've stated clearly that there 
should be no new sysfs configuration files when we switch to genl.

If it now preferred to have sysfs again for configuration then please discuss 
it with the netdev folks and find out how the new generic netlink interface 
can be removed again before the next release.

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)