netdev - dead code in vhost.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214080346.352c6941@shemminger-XPS-13-9360>
Date:   Thu, 14 Feb 2019 08:03:46 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     mst@...hat.com, jasowang@...hat.com
Cc:     netdev@...r.kernel.org
Subject: dead code in vhost.c


Coverity found this obvious bug

________________________________________________________________________________________________________
*** CID 1442593:  Control flow issues  (DEADCODE)
/drivers/vhost/vhost.c: 1795 in log_used()
1789     	ret = translate_desc(vq, (uintptr_t)vq->used + used_offset,
1790     			     len, iov, 64, VHOST_ACCESS_WO);
1791     	if (ret)
1792     		return ret;
1793     
1794     	for (i = 0; i < ret; i++) {
>>>     CID 1442593:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "ret = log_write_hva(vq, (ui...".  
1795     		ret = log_write_hva(vq,	(uintptr_t)iov[i].iov_base,
1796     				    iov[i].iov_len);
1797     		if (ret)
1798     			return ret;
1799     	}
1800