lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190214082913.7e2f7897@shemminger-XPS-13-9360> Date: Thu, 14 Feb 2019 08:29:13 -0800 From: Stephen Hemminger <stephen@...workplumber.org> To: Matteo Croce <mcroce@...hat.com> Cc: netdev <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Jakub Kicinski <jakub.kicinski@...ronome.com> Subject: Re: [PATCH iproute2] iplink: document XDP subcommand to force the XDP mode. On Thu, 14 Feb 2019 15:01:26 +0100 Matteo Croce <mcroce@...hat.com> wrote: > On Wed, Feb 13, 2019 at 11:04 PM Stephen Hemminger > <stephen@...workplumber.org> wrote: > > > > On Wed, 13 Feb 2019 15:40:30 +0100 > > Matteo Croce <mcroce@...hat.com> wrote: > > > > > When attaching an eBPF program to a device, ip link can force the XDP mode > > > by using the xdp{generic,drv,offload} keyword instead of just 'xdp'. > > > Document this behaviour also in the help output. > > > > > > Signed-off-by: Matteo Croce <mcroce@...hat.com> > > > Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode") > > > Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload") > > > > Applied, thanks. > > The man page already has this as well. > > > > Yes, I found it just after I made the patch. However, it could be nice > to have the generic "xdp" and a command like "type" or "mode" to > specify the XDP mode, eg. > ip link set dev eth0 xdp mode [ auto | generic | drv | offload ] > I was trying to add it, but unfortunately it seems that the arguments > aren't parsed in a loop, and are required to be in the exact order. > Would this change make sense? > > Regards, > > -- > Matteo Croce > per aspera ad upstream It would have made sense to start with, but the syntax is more or less fixed by now.
Powered by blists - more mailing lists