lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <44b0b277-713e-012f-a6cf-402c46a8d92b@gmail.com> Date: Wed, 13 Feb 2019 20:10:35 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Russell King - ARM Linux <linux@...linux.org.uk> Subject: Re: [PATCH net] net: phy: fix interrupt handling in non-started states On 2/12/2019 10:56 AM, Heiner Kallweit wrote: > phylib enables interrupts before phy_start() has been called, and if > we receive an interrupt in a non-started state, the interrupt handler > returns IRQ_NONE. This causes problems with at least one Marvell chip > as reported by Andrew. > Fix this by handling interrupts the same as in phy_mac_interrupt(), > basically always running the phylib state machine. It knows when it > has to do something and when not. > This change allows to handle interrupts gracefully even if they > occur in a non-started state. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Reported-by: Andrew Lunn <andrew@...n.ch> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists