netdev - Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for SGE doorbell queue timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190213.221043.122004348292926904.davem@davemloft.net>
Date:   Wed, 13 Feb 2019 22:10:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vishal@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for SGE
 doorbell queue timer

From: Vishal Kulkarni <vishal@...lsio.com>
Date: Wed, 13 Feb 2019 10:44:03 +0530

> T6 introduced a Timer Mechanism in SGE called the
> SGE Doorbell Queue Timer. With this we can now configure
> TX Queues to get CIDX Updates when:
> 
>     Time(CIDX == PIDX) >= Timer
> 
> Previously we rely on TX Queue Status Page updates by hardware
> for DMA completions. This will make Hardware/Firmware actually
> deliver the CIDX Updates as Ingress Queue messages with
> commensurate Interrupts.
> 
> So we now have a new RX Path component for processing CIDX Updates
> and reclaiming TX Descriptors faster.
> 
> Original work by: Casey Leedom <leedom@...lsio.com>
> 
> Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>

Can you at least fix the reverse christmas tree situation for the functions
where you add or remove local variables?

Thank you.