lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190215142749.GD5784@redhat.com> Date: Fri, 15 Feb 2019 12:27:49 -0200 From: Arnaldo Carvalho de Melo <acme@...hat.com> To: Song Liu <songliubraving@...com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, kernel-team@...com, peterz@...radead.org, jolsa@...nel.org, namhyung@...nel.org Subject: Re: [PATCH v2 perf,bpf 09/11] perf-top: add option --bpf-event Em Thu, Feb 14, 2019 at 04:00:10PM -0800, Song Liu escreveu: > bpf events are only tracked when opts->bpf_event is enabled. This patch > adds command line flag to enable this for perf-top. Shouldn't this start as enabled and we just provide a way to disable it for testing purposes? Normally perf top works system wide, and then we want to get info about BPF events, I think. - Arnaldo > Signed-off-by: Song Liu <songliubraving@...com> > --- > tools/perf/builtin-top.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > index 27d8d42e0a4d..5271d7211b9c 100644 > --- a/tools/perf/builtin-top.c > +++ b/tools/perf/builtin-top.c > @@ -1492,6 +1492,7 @@ int cmd_top(int argc, const char **argv) > "Display raw encoding of assembly instructions (default)"), > OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel, > "Enable kernel symbol demangling"), > + OPT_BOOLEAN(0, "bpf-event", &opts->bpf_event, "record bpf events"), > OPT_STRING(0, "objdump", &top.annotation_opts.objdump_path, "path", > "objdump binary to use for disassembly and annotations"), > OPT_STRING('M', "disassembler-style", &top.annotation_opts.disassembler_style, "disassembler style", > -- > 2.17.1
Powered by blists - more mailing lists