netdev - Re: [net-next 5/5] net: sock: remove the definition of SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALOAHbCGxQ0msoYstFmjCNkpNX1rfqWyzg_2KmrWh_ST=8sycg@mail.gmail.com>
Date:   Fri, 15 Feb 2019 23:41:26 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        netdev <netdev@...r.kernel.org>, shaoyafang@...iglobal.com
Subject: Re: [net-next 5/5] net: sock: remove the definition of SOCK_DEBUG()

On Fri, Feb 15, 2019 at 10:58 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Fri, Feb 15, 2019 at 6:50 AM Yafang Shao <laoar.shao@...il.com> wrote:
> >
> > As SOCK_DEBUG() isn't used any more, we can get ride of it now.
> >
>
> No, we are still using this infrastructure from time to time.
>
> I told you I agreed to remove the current (obsolete) TCP call sites,
>  I never suggested to remove SOCK_DEBUG() completely.

All right, however I'm not persuaded by you.
Because SOCK_DEBUG() is not a smart way for debugging, which requires
the user code to be modified.
We have other more flexible methords.


Thanks
Yafang