netdev - Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSeRV3Qy_S3c4qayTe3K1FkaPF7cZnV7_tNVKnS3cEuxmA@mail.gmail.com>
Date:   Fri, 15 Feb 2019 11:58:35 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Alexey Kodanev <alexey.kodanev@...cle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Petr Vorel <pvorel@...e.cz>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] sock: return uapi errno in sock_setsockopt() for SO_ZEROCOPY

On Fri, Feb 15, 2019 at 11:51 AM Alexey Kodanev
<alexey.kodanev@...cle.com> wrote:
>
> For unsupported protocols, setsockopt() with SO_ZEROCOPY
> option sets errno to ENOTSUPP(524). But this number is
> not defined anywhere in the include/uapi/ headers.
>
> To make sure userspace sees the known number, replace
> ENOTSUPP(524) with EOPNOTSUPP(95).
>
> Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt")
> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>
> Reported-by: Petr Vorel <pvorel@...e.cz>

This code has been there since 4.14. I think it's too late to change
system call behavior.