lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Feb 2019 09:36:36 -0800
From:   Eric Dumazet <>
To:     Willem de Bruijn <>,
Cc:,,,, Willem de Bruijn <>,
        syzbot <>
Subject: Re: [PATCH net] net: validate untrusted gso packets without csum

On 02/15/2019 09:15 AM, Willem de Bruijn wrote:
> From: Willem de Bruijn <>
> Syzkaller again found a path to a kernel crash through bad gso input.
> By building an excessively large packet to cause an skb field to wrap.
> If VIRTIO_NET_HDR_F_NEEDS_CSUM was set this would have been dropped in
> skb_partial_csum_set.
> GSO packets that do not set checksum offload are suspicious and rare.
> Most callers of virtio_net_hdr_to_skb already pass them to
> skb_probe_transport_header.
> Move that test forward, change it to detect parse failure and drop
> packets on failure as those cleary are not one of the legitimate
> Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")
> Fixes: f43798c27684 ("tun: Allow GSO using virtio_net_hdr")
> Reported-by: syzbot <>
> Signed-off-by: Willem de Bruijn <>

Reviewed-by: Eric Dumazet <>

Powered by blists - more mailing lists