netdev - Re: [PATCH bpf-next] bpf: make LWTUNNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFTs51WUDJSYUryqECcY1GN_O9fnHz8nvgSNv2raWo+=G-ygbw@mail.gmail.com>
Date:   Fri, 15 Feb 2019 09:53:44 -0800
From:   Peter Oskolkov <posk@...k.io>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Peter Oskolkov <posk@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: make LWTUNNEL_BPF dependent on INET

On Fri, Feb 15, 2019 at 9:46 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
>
> On 02/15/2019 09:40 AM, Peter Oskolkov wrote:
> > Lightweight tunnels are L3 constructs that are used with IP/IP6.
> > Make the dependency explicit at least for LWT-BPF, as now they
> > call into IP routing.
> >
> > Signed-off-by: Peter Oskolkov <posk@...gle.com>
> > ---
> >  net/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 5cb9de1aaf88..62da6148e9f8 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -403,7 +403,7 @@ config LWTUNNEL
> >
> >  config LWTUNNEL_BPF
> >       bool "Execute BPF program as route nexthop action"
> > -     depends on LWTUNNEL
> > +     depends on LWTUNNEL && INET
> >       default y if LWTUNNEL=y
> >       ---help---
> >         Allows to run BPF programs as a nexthop action following a route
> >
>
> It seems you forgot a 'Reported-by:' tag

Fixed: https://patchwork.ozlabs.org/patch/1043108/

>
> Thanks.