netdev - Re: [PATCH] net: Fix for_each_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190216.134601.2089518577404430254.davem@davemloft.net>
Date:   Sat, 16 Feb 2019 13:46:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     hauke.mehrtens@...el.com, netdev@...r.kernel.org, jarod@...hat.com,
        hauke@...ke-m.de, stable@...r.kernel.org
Subject: Re: [PATCH] net: Fix for_each_netdev_feature on Big endian

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 16 Feb 2019 13:01:28 -0800

> This commit added a call to fls64(), but not the needed include.
> 
> This might break some uses I think.
> 
> I suggest the following fix :
> 
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> index c50cedb65cf56fe7d722a5a321b714ed83f449a0..d3f61011f4346e4ea80b61f88bd24541dd006014 100644
> --- a/include/linux/netdev_features.h
> +++ b/include/linux/netdev_features.h
> @@ -11,6 +11,7 @@
>  #define _LINUX_NETDEV_FEATURES_H
>  
>  #include <linux/types.h>
> +#include <linux/bitops.h>
>  #include <asm/byteorder.h>
>  
>  typedef u64 netdev_features_t;

Ok I'm build testing that right now, thanks.

====================
>From 8681ef1f3d295bd3600315325f3b3396d76d02f6 Mon Sep 17 00:00:00 2001
From: "David S. Miller" <davem@...emloft.net>
Date: Sat, 16 Feb 2019 13:44:39 -0800
Subject: [PATCH] net: Add header for usage of fls64()

Fixes: 3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian")
Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 include/linux/netdev_features.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index fce28562bed2..4c76fe2c8488 100644
--- a/include/linux/netdev_features.h
+++ b/include/linux/netdev_features.h
@@ -11,6 +11,7 @@
 #define _LINUX_NETDEV_FEATURES_H
 
 #include <linux/types.h>
+#include <linux/bitops.h>
 #include <asm/byteorder.h>
 
 typedef u64 netdev_features_t;
-- 
2.20.1