netdev - Re: [PATCH bpf-next] selftests: bpf: test_lwt_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8a76f3d-93e8-1287-05e0-a671a3991cbe@gmail.com>
Date:   Sat, 16 Feb 2019 16:13:12 -0700
From:   David Ahern <dsahern@...il.com>
To:     Peter Oskolkov <posk@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Cc:     Peter Oskolkov <posk@...k.io>
Subject: Re: [PATCH bpf-next] selftests: bpf: test_lwt_ip_encap: add negative
 tests.

On 2/15/19 4:49 PM, Peter Oskolkov wrote:
> @@ -178,7 +205,7 @@ set -e  # exit on error
>  	# configure IPv4 GRE device in NS3, and a route to it via the "bottom" route
>  	ip -netns ${NS3} tunnel add gre_dev mode gre remote ${IPv4_1} local ${IPv4_GRE} ttl 255
>  	ip -netns ${NS3} link set gre_dev up
> -	ip -netns ${NS3} addr add ${IPv4_GRE} dev gre_dev
> +	ip -netns ${NS3} addr add ${IPv4_GRE} nodad dev gre_dev

nodad is only effective for IPv6.

other than that LGTM. Thanks for the update.

Reviewed-by: David Ahern <dsahern@...il.com>