netdev - Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvb5nTBSn54CqsNjvAFfLN2Hjf9MO3smiCNp3m94DytXnA@mail.gmail.com>
Date:   Fri, 15 Feb 2019 21:31:21 -0500
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        soukjin bae <soukjin.bae@...sung.com>
Subject: Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful

On Fri, Feb 15, 2019 at 9:21 PM Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > ICMP handlers are not very often stressed, we should
> > make them more resilient to bugs that might surface in
> > the future.
> >
> > If there is no packet in retransmit queue, we should
> > avoid a NULL deref.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Reported-by: soukjin bae <soukjin.bae@...sung.com>
> > ---
> >  net/ipv4/tcp_ipv4.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Thanks you for the fix, Eric!

>
> Thanks!
>
> neal