netdev - Re: [PATCH] atm: clean up vcc_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190216.181435.357732120744308938.davem@davemloft.net>
Date:   Sat, 16 Feb 2019 18:14:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     joe@...ches.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] atm: clean up vcc_seq_next()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 14 Feb 2019 09:56:35 +0300

> It's confusing to call PTR_ERR(v).  The PTR_ERR() function is basically
> a fancy cast to long so it makes you wonder, was IS_ERR() intended?  But
> that doesn't make sense because vcc_walk() doesn't return error
> pointers.
> 
> This patch doesn't affect runtime, it's just a cleanup.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.