lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Feb 2019 09:02:39 +0100 From: Heiner Kallweit <hkallweit1@...il.com> To: Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 1/2] net: phy: add helper mii_10gbt_stat_mod_linkmode_lpa_t On 17.02.2019 03:35, Florian Fainelli wrote: > > > On 2/16/2019 8:26 AM, Heiner Kallweit wrote: >> Similar to the existing helpers for the Clause 22 registers add helper >> mii_10gbt_stat_mod_linkmode_lpa_t. >> >> Note that this helper is defined in linux/mdio.h, not like the >> Clause 22 helpers in linux/mii.h. Reason is that the Clause 45 register >> constants are defined in uapi/linux/mdio.h. And uapi/linux/mdio.h >> includes linux/mii.h before defining the C45 register constants. > > Nit: this also processes 2.5G and 5G but I can't suggest a better name, > so this is as good as any. > I also thought about this and eventually decided to go with the register name from the Clause 45 (2015) spec. Not sure whether there's a newer version, but even if I (after 802.3bz was established) doubt that they would rename a register. >> >> v2: >> - remove helpers that don't have users in this series >> >> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> > > Reviewed-by: Florian Fainelli <f.fainelli@...il.com> >
Powered by blists - more mailing lists