lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6ef2f327-8dc6-4c86-f42d-4aa7508d19f5@intel.com> Date: Sun, 17 Feb 2019 12:06:21 +0200 From: "Neftin, Sasha" <sasha.neftin@...el.com> To: Wei Yongjun <weiyongjun1@...wei.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static On 2/16/2019 04:04, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning: > symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static? > > Fixes: 8c5ad0dae93c ("igc: Add ethtool support") > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> > --- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c > index eff37a6c0afa..544239422577 100644 > --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c > +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c > @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev, > return 0; > } > > -void igc_write_rss_indir_tbl(struct igc_adapter *adapter) > +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter) > { > struct igc_hw *hw = &adapter->hw; > u32 reg = IGC_RETA(0); > > > NACK 'igc_write_rss_indir_tbl' method declared in igc.h file. This method used in both igc_ethtool.c and igc_main.c and can't be a 'static'
Powered by blists - more mailing lists