netdev - Re: [PATCH net] mlxsw: __mlxsw_sp_port_headroom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190217.101440.744217887687576351.davem@davemloft.net>
Date:   Sun, 17 Feb 2019 10:14:40 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net] mlxsw: __mlxsw_sp_port_headroom_set(): Fix a use
 of local variable

From: Ido Schimmel <idosch@...lanox.com>
Date: Sun, 17 Feb 2019 07:18:41 +0000

> From: Petr Machata <petrm@...lanox.com>
> 
> The function-local variable "delay" enters the loop interpreted as delay
> in bits. However, inside the loop it gets overwritten by the result of
> mlxsw_sp_pg_buf_delay_get(), and thus leaves the loop as quantity in
> cells. Thus on second and further loop iterations, the headroom for a
> given priority is configured with a wrong size.
> 
> Fix by introducing a loop-local variable, delay_cells. Rename thres to
> thres_cells for consistency.
> 
> Fixes: f417f04da589 ("mlxsw: spectrum: Refactor port buffer configuration")
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable, thanks Ido.