netdev - RE: [PATCH net-next] bnx2x: Remove set but not used variable 'mfw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR18MB1253E984E16BAAEE9C72B682D3630@CY4PR18MB1253.namprd18.prod.outlook.com>
Date:   Mon, 18 Feb 2019 14:40:20 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        Ariel Elior <aelior@...vell.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH net-next] bnx2x: Remove set but not used variable 'mfw_vn'

>-----Original Message-----
>From: YueHaibing [mailto:yuehaibing@...wei.com]
>Sent: 18 February 2019 17:50
>To: Ariel Elior <aelior@...vell.com>; Sudarsana Reddy Kalluru
><skalluru@...vell.com>; David S . Miller <davem@...emloft.net>
>Cc: YueHaibing <yuehaibing@...wei.com>; GR-everest-linux-l2 <GR-everest-
>linux-l2@...vell.com>; netdev@...r.kernel.org; kernel-
>janitors@...r.kernel.org
>Subject: [PATCH net-next] bnx2x: Remove set but not used variable 'mfw_vn'
>
>Fixes gcc '-Wunused-but-set-variable' warning:
>
>drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function
>'bnx2x_get_hwinfo':
>drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:11940:10: warning:
> variable 'mfw_vn' set but not used [-Wunused-but-set-variable]
>
>It's never used since introduction.
>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>index 3b5b47e98c73..7c47be215a34 100644
>--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>@@ -11998,7 +11998,7 @@ static void validate_set_si_mode(struct bnx2x
>*bp)  static int bnx2x_get_hwinfo(struct bnx2x *bp)  {
> 	int /*abs*/func = BP_ABS_FUNC(bp);
>-	int vn, mfw_vn;
>+	int vn;
> 	u32 val = 0, val2 = 0;
> 	int rc = 0;
>
>@@ -12083,12 +12083,10 @@ static int bnx2x_get_hwinfo(struct bnx2x *bp)
> 	/*
> 	 * Initialize MF configuration
> 	 */
>-
> 	bp->mf_ov = 0;
> 	bp->mf_mode = 0;
> 	bp->mf_sub_mode = 0;
> 	vn = BP_VN(bp);
>-	mfw_vn = BP_FW_MB_IDX(bp);
>
> 	if (!CHIP_IS_E1(bp) && !BP_NOMCP(bp)) {
> 		BNX2X_DEV_INFO("shmem2base 0x%x, size %d, mfcfg offset
>%d\n",
>
>

Acked-by: Sudarsana Reddy Kalluru <skalluru@...vell.com>