netdev - Re: stmmac / meson8b-dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adafe6d7-e619-45e9-7ecb-76f003b0c7d9@synopsys.com>
Date:   Mon, 18 Feb 2019 17:05:57 +0000
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     Simon Huelck <simonmail@....de>,
        Jose Abreu <jose.abreu@...opsys.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
CC:     Emiliano Ingrassia <ingrassia@...genesys.com>,
        <Gpeppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <linux-amlogic@...ts.infradead.org>, <netdev@...r.kernel.org>
Subject: Re: stmmac / meson8b-dwmac

On 2/18/2019 4:51 PM, Simon Huelck wrote:
> Hi,
> 
> no im testing vanilla mainline kernel and against 4.14. where
> performance was ok. but turning off EEE via ethtool should have same
> results than removal of that patch.
> 
> But, since it was mainlined recently , not long ago, i think this was
> tested ??

The thing is that phy_init_eee() is called by stmmac and this
function does not take into account the broken modes if it's
called too early which will cause driver to enable LPI in MAC.

And anyway, if you have lpi values in the ethtool stats then EEE
is being enabled by stmmac.

Please try the change I suggested.

Thanks,
Jose Miguel Abreu