lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190218192020.5c83a494@redhat.com> Date: Mon, 18 Feb 2019 19:20:20 +0100 From: Stefano Brivio <sbrivio@...hat.com> To: Vlad Buslov <vladbu@...lanox.com>, "jiri@...nulli.us" <jiri@...nulli.us> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jhs@...atatu.com" <jhs@...atatu.com>, "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [PATCH net-next 02/12] net: sched: flower: refactor fl_change On Fri, 15 Feb 2019 16:25:52 +0000 Vlad Buslov <vladbu@...lanox.com> wrote: > On Fri 15 Feb 2019 at 10:47, Stefano Brivio <sbrivio@...hat.com> wrote: > > > Ah, of course. Thanks for clarifying. By the way, what tricked me here > > was this check in fl_change(): > > > > if (fold && handle && fold->handle != handle) > > ... > > > > which could be turned into: > > > > if (fold && fold->handle != handle) > > ... > > > > at this point. > > At this point I don't think this check is needed at all because fold > can't suddenly change its handle in between this check and initial > lookup in cls API. Oh, right. > Looking at commit history, this check is present since original commit > by Jiri that implements flower classifier. Maybe semantics of cls API > was different back then? I wasn't able to figure that out either... Jiri? -- Stefano
Powered by blists - more mailing lists