netdev - Re: [PATCH net-next 0/2] tracepoints in neighbor subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 10:23:06 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: [PATCH net-next 0/2] tracepoints in neighbor subsystem

On Sun, Feb 17, 2019 at 10:34 AM David Miller <davem@...emloft.net> wrote:
>
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> Date: Thu, 14 Feb 2019 09:15:09 -0800
>
> > From: Roopa Prabhu <roopa@...ulusnetworks.com>
> >
> > Roopa Prabhu (2):
> >   trace: events: add a few neigh tracepoints
> >   neigh: hook tracepoints in neigh update code
>
> Series applied, thanks.
>
> Maybe put some actual text in this intro posting next time, explaining
> what the series is doing, how it is doing it, and why?
>

Oops, My bad. I did have text here in my initial version and possibly
accidentally dropped it when re-generating the cover-letter multiple
times. And absolutely, will keep an eye out to make sure it is
complete next time on. Thanks.


Here are some examples of perf report outputs for neigh creates and
deletes (if anyone wants to review further).
As i type this i realized I missed the converting of new_state to
string. Will send a patch to fix it.

# create a neigh
$ip neigh add 45.0.1.100 dev vlan1001 lladdr 00:02:00:00:00:aa nud reachable

ip  3964 [000] 52484.852372:              neigh:neigh_update: family 2
dev vlan1001 lladdr 000000000000 flags 00 nud_state 0x0 type 01 dead 0
refcnt 2 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4344992162 updated 4347152162 used 4347152162 new_lladdr
0002000000aa new_state 02 update_flags 80000005 pid 3964

ip  3964 [000] 52484.852446:         neigh:neigh_update_done: family 2
dev vlan1001 lladdr 0002000000aa flags 00 nud_state reachable type 01
dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152162 updated 4347152162 used 4347152162 err 0

# change of lladdr on existing neigh
$ip neigh replace 45.0.1.100 dev vlan1001 lladdr 00:02:00:00:00:bb nud reachable

ip  3965 [000] 52484.855838:              neigh:neigh_update: family 2
dev vlan1001 lladdr 0002000000aa flags 00 nud_state reachable type 01
dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152162 updated 4347152162 used 4347152162 new_lladdr
0002000000bb new_state 02 update_flags 80000005 pid 3965

ip  3965 [000] 52484.855883:         neigh:neigh_update_done: family 2
dev vlan1001 lladdr 0002000000bb flags 00 nud_state reachable type 01
dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152165 updated 4347152165 used 4347152162 err 0


# neigh delete, update comes in with NUD_FAILED
$ip neigh del 45.0.1.100 dev vlan1001

ip  3966 [000] 52484.859354:              neigh:neigh_update: family 2
dev vlan1001 lladdr 0002000000bb flags 00 nud_state reachable type 01
dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152165 updated 4347152165 used 4347152162 new_lladdr
00000000766c new_state 20 update_flags 80000001 pid 3966

ip  3966 [000] 52484.859397:         neigh:neigh_update_done: family 2
dev vlan1001 lladdr 0002000000bb flags 00 nud_state failed type 01
dead 0 refcnt 2 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152165 updated 4347152165 used 4347152162 err 0

ip  3966 [000] 52484.859401: neigh:neigh_cleanup_and_release: family 2
dev vlan1001 lladdr 0002000000bb flags 00 nud_state failed type 01
dead 1 refcnt 1 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347152165 updated 4347152165 used 4347152162 err 0


# readd neigh entry and allow it to age, this time
$ip neigh add 45.0.1.100 dev vlan1001 lladdr 00:02:00:00:00:aa nud reachable

ip  4165 [000] 52519.192502:              neigh:neigh_update: family 2
dev vlan1001 lladdr 000000000000 flags 00 nud_state 0x0 type 01 dead 0
refcnt 2 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4345026502 updated 4347186502 used 4347186502 new_lladdr
0002000000aa new_state 02 update_flags 80000005 pid 4165

ip  4165 [000] 52519.192562:         neigh:neigh_update_done: family 2
dev vlan1001 lladdr 0002000000aa flags 00 nud_state reachable type 01
dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347186502 updated 4347186502 used 4347186502 err 0

swapper     0 [000] 53220.306184:       neigh:neigh_timer_handler:
family 2 dev vlan1001 lladdr 0002000000aa flags 00 nud_state reachable
type 01 dead 0 refcnt 3 primary_key4 45.0.1.100 primary_key6
::ffff:45.0.1.100 confirmed 4347186502 updated 4347186502 used
4347186502 err 0

swapper     0 [000] 53973.970238:       neigh:neigh_timer_handler:
family 2 dev vlan1001 lladdr 0002000000aa flags 00 nud_state stale
type 01 dead 0 refcnt 2 primary_key4 45.0.1.100 primary_key6
::ffff:45.0.1.100 confirmed 4347186502 updated 4348641280 used
4347186502 err 0

ip 10268 [000] 65338.084401: neigh:neigh_cleanup_and_release: family 2
dev vlan1001 lladdr 0002000000aa flags 00 nud_state stale type 01 dead
1 refcnt 1 primary_key4 45.0.1.100 primary_key6 ::ffff:45.0.1.100
confirmed 4347186502 updated 4348641280 used 4347186502 err 0