lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190218.153310.393264778478086662.davem@davemloft.net> Date: Mon, 18 Feb 2019 15:33:10 -0800 (PST) From: David Miller <davem@...emloft.net> To: vlomovtsev@...vell.com Cc: sgoutham@...ium.com, rric@...nel.org, linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, dnelson@...hat.com Subject: Re: [PATCH v2 3/8] net: thunderx: make CFG_DONE message to run through generic send-ack sequence From: Vadim Lomovtsev <vlomovtsev@...vell.com> Date: Mon, 18 Feb 2019 09:52:14 +0000 > @@ -169,6 +169,20 @@ static int nicvf_check_pf_ready(struct nicvf *nic) > return 1; > } > > +static int nicvf_send_cfg_done(struct nicvf *nic) > +{ > + union nic_mbx mbx = {}; > + > + mbx.msg.msg = NIC_MBOX_MSG_CFG_DONE; > + if (nicvf_send_msg_to_pf(nic, &mbx)) { > + netdev_err(nic->netdev, > + "PF didn't respond to CFG DONE msg\n"); > + return 0; > + } > + > + return 1; > +} ... > @@ -1515,8 +1528,7 @@ int nicvf_open(struct net_device *netdev) > nicvf_enable_intr(nic, NICVF_INTR_RBDR, qidx); > > /* Send VF config done msg to PF */ > - mbx.msg.msg = NIC_MBOX_MSG_CFG_DONE; > - nicvf_write_to_mbx(nic, &mbx); > + nicvf_send_cfg_done(nic); If the one and only call site doesn't even bother to check the return value, just make it return void. Thanks.
Powered by blists - more mailing lists