netdev - NET_RX_DROP vs dev->stats.rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d3885d8619086dce1b91c85610cfead32ffebf96.camel@infinera.com>
Date:   Mon, 18 Feb 2019 08:30:56 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: NET_RX_DROP vs dev->stats.rx_dropped++ in drivers

We have noticed odd dropped packets in a few cases and these comes from
drivers that do this:
...
	dropped = netif_rx(sb);
	if (dropped == NET_RX_DROP) {
		dev->stats.rx_dropped++;
...

This seems a bit odd to me, should drivers account for dropped pkgs in this case?

 Jocke