lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <60e0143b-9032-4c31-0dbb-9f2518f79601@free.fr> Date: Tue, 19 Feb 2019 13:41:37 +0100 From: Marc Gonzalez <marc.w.gonzalez@...e.fr> To: Niklas Cassel <niklas.cassel@...aro.org> Cc: Vinod Koul <vkoul@...nel.org>, David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, MSM <linux-arm-msm@...r.kernel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Nori Sekhar <nsekhar@...com>, Peter Ujfalusi <peter.ujfalusi@...com> Subject: Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode On 19/02/2019 13:33, Niklas Cassel wrote: > However, since the bootloader might have enabled delay on > TX, I still think that this patch does the right thing by > starting out with disabling delays for both RX and TX. > > But we should probably make the comment more elaborate: > > The value after HW reset is RX delay enabled and TX delay disabled. > The value after SW reset is RX delay enabled, while TX delay retains > the value before reset. > In order to not depend on reset values, start off by disabling both > delays. Ultimately, the two patches do the same thing, AFAICT ;-) I was just arguing that my way was better because... errr... because it was my way! :-) Regards.
Powered by blists - more mailing lists