netdev - Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for netlink interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 14:07:23 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for
 netlink interface

On Mon, Feb 18, 2019 at 12:15:17PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote:
> > +/* create skb for a reply and fill device identification
> > + * payload: payload length (without netlink and genetlink header)
> > + * dev:     device the reply is about (may be null)
> > + * cmd:     ETHNL_CMD_* command for reply
> > + * info:    info for the received packet we respond to
> > + * ehdrp:   place to store payload pointer returned by genlmsg_new()
> > + * returns: skb or null on error
> > + */
> 
> nit: why not correct kdoc?

Good point. I'll fix that, together with the other things.

Michal

> 
> > +struct sk_buff *ethnl_reply_init(size_t payload, struct net_device *dev, u8 cmd,
> > +				 u16 dev_attrtype, struct genl_info *info,
> > +				 void **ehdrp)
> > +{
> > +	void *ehdr;
> > +	struct sk_buff *rskb;
> 
> nit: reverse xmas tree