netdev - Re: [PATCH bpf-next v2] bpf: bpftool, fix documentation for attach types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40462bbf-b236-5d96-6827-e1965566d453@netronome.com>
Date:   Tue, 19 Feb 2019 14:19:09 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Alban Crequy <alban.crequy@...il.com>, ast@...nel.org,
        daniel@...earbox.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        john.fastabend@...il.com, alban@...volk.io, iago@...volk.io
Subject: Re: [PATCH bpf-next v2] bpf: bpftool, fix documentation for attach
 types

2019-02-19 15:13 UTC+0100 ~ Alban Crequy <alban.crequy@...il.com>
> From: Alban Crequy <alban@...volk.io>
> 
> bpftool has support for attach types "stream_verdict" and
> "stream_parser" but the documentation was referring to them as
> "skb_verdict" and "skb_parse". The inconsistency comes from commit
> b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to
> maps").
> 
> This patch changes the documentation to match the implementation:
> - "bpftool prog help"
> - man pages
> - bash completion
> 
> Signed-off-by: Alban Crequy <alban@...volk.io>
> 
> ---
> 
> Changes v1 to v2:
> - fix man pages & bash completion (from Quentin's review)


Thanks a lot!

Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>