netdev - Re: [PATCH bpf-next] bpf: add skb->queue_mapping write access from tc clsact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1ed8f33-bdfa-85a3-7291-d0ee7c3f209e@iogearbox.net>
Date:   Tue, 19 Feb 2019 17:08:50 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [PATCH bpf-next] bpf: add skb->queue_mapping write access from tc
 clsact

On 02/19/2019 04:57 PM, Jesper Dangaard Brouer wrote:
> On Tue, 19 Feb 2019 12:46:57 +0100
> Daniel Borkmann <daniel@...earbox.net> wrote:
> 
>>> Due to lack of TC examples, lets show howto attach clsact BPF programs:
>>>
>>>  # tc qdisc  add     dev ixgbe2 clsact
>>>  # tc filter replace dev ixgbe2 egress bpf da obj XXX_kern.o sec tc_qmap2cpu
>>>  # tc filter list    dev ixgbe2 egress
> 
> Recommending the "replace" is wrong is seems, as does not replace the
> existing, but keeps adding more filter entries.
> 
> What is the recommended procedure for unloading and loading a newer
> version of the BPF TC program?

You would need to specify prio / handle in order to select a particular
instance for atomic replacement:

tc filter replace dev foo {e,in}gress prio 1 handle 1 bpf da obj foo.o