netdev - Re: [PATCH][net-next] bridge: remove redundant check on err in br_multicast_ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJieiUjTwPasRWVB6aUP_hYW4jGZe7AfNi1CECzX1DbDdJnRXQ@mail.gmail.com>
Date:   Tue, 19 Feb 2019 09:27:58 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Li RongQing <lirongqing@...du.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH][net-next] bridge: remove redundant check on err in br_multicast_ipv4_rcv

On Mon, Feb 18, 2019 at 6:17 PM Li RongQing <lirongqing@...du.com> wrote:
>
> br_ip4_multicast_mrd_rcv only return 0 and -ENOMSG,
> no other negative value
>
> Signed-off-by: Li RongQing <lirongqing@...du.com>

Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

looks fine to me. CC Nikolay



>  net/bridge/br_multicast.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 4a048fd1cbea..fe9f2d8ca2c1 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1615,12 +1615,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
>                         if (ip_hdr(skb)->protocol == IPPROTO_PIM)
>                                 br_multicast_pim(br, port, skb);
>                 } else if (ipv4_is_all_snoopers(ip_hdr(skb)->daddr)) {
> -                       err = br_ip4_multicast_mrd_rcv(br, port, skb);
> -
> -                       if (err < 0 && err != -ENOMSG) {
> -                               br_multicast_err_count(br, port, skb->protocol);
> -                               return err;
> -                       }
> +                       br_ip4_multicast_mrd_rcv(br, port, skb);
>                 }
>
>                 return 0;
> --
> 2.16.2
>