netdev - Re: [PATCH iproute2, v2] ip-rule: fix json key "to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190219152206.7d79da00@shemminger-XPS-13-9360>
Date:   Tue, 19 Feb 2019 15:22:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Thomas Haller <thaller@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2, v2] ip-rule: fix json key "to_tbl" for
 unspecific rule action

On Tue, 19 Feb 2019 21:50:19 +0100
Thomas Haller <thaller@...hat.com> wrote:

> The key should not be called "to_tbl" because it is exactly
> not a FR_ACT_TO_TBL action. Change it to "action".
> 
>     # ip rule add blackhole
>     # ip -j rule | python -m json.tool
>     ...
>     {
>         "priority": 0,
>         "src": "all",
>         "to_tbl": "blackhole"
>     },
> 
> This is an API break of JSON output as it was added in v4.17.0.
> Still change it as the API is relatively new and unstable.
> 
> Fixes: 0dd4ccc56c0e ("iprule: add json support")
> 
> Signed-off-by: Thomas Haller <thaller@...hat.com>

Applied, thanks.