netdev - Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 10:32:27 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, niklas.cassel@...aro.org, andrew@...n.ch,
        f.fainelli@...il.com, nsekhar@...com, peter.ujfalusi@...com,
        marc.w.gonzalez@...e.fr
Subject: Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers

Hello Dave,

On 18-02-19, 16:28, David Miller wrote:
> From: Vinod Koul <vkoul@...nel.org>
> Date: Mon, 18 Feb 2019 15:48:52 +0530
> 
> > Some helpers were inlined, but makes more sense to allow compiler
> > to do the right optiomazations instead, so remove inline for
> > at803x_disable_rx_delay() and at803x_disable_tx_delay()
> > 
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> 
> Two problem with this patch series.
> 
> 1) It fixes a bug in 'net' but the patches only apply cleanly to
>    'net-next'.  Please respin this against 'net'.

I assume the 'net' is fixes going into current -rcX. This fixes issues
reported on linux-next due to patches in net-next, so these fixes should
go to net-next as well.

> 2) This series lacks a header posting "[PATCH vX 0/N] " which
>    explains at a high level what the series is doing, how it is
>    doing it, and why it is doing it that way.

Sure I will add this and repost

Thanks
-- 
~Vinod