lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM_iQpWXF1Yq2Yic0J3KTxo+h5UQTc1vwEcR-cs1424dnxd9-g@mail.gmail.com> Date: Mon, 18 Feb 2019 21:26:57 -0800 From: Cong Wang <xiyou.wangcong@...il.com> To: Vlad Buslov <vladbu@...lanox.com> Cc: Ido Schimmel <idosch@...sch.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jhs@...atatu.com" <jhs@...atatu.com>, "jiri@...nulli.us" <jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>, "ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net> Subject: Re: [PATCH net-next v4 07/17] net: sched: protect filter_chain list with filter_chain_lock mutex On Fri, Feb 15, 2019 at 7:35 AM Vlad Buslov <vladbu@...lanox.com> wrote: > > Another problem that I found in cls_fw and cls_route is that they set > arg->stop when empty. Both of them have code unchanged since it was > committed initially in 2005 so I assume this convention is no longer > relevant because all other classifiers don't do that (they only set > arg->stop when arg->fn returns negative value). > The question is why do you want to use arg->stop==0 as an indication for emptiness? Isn't what arg->count==0 supposed to be?
Powered by blists - more mailing lists